lkml.org 
[lkml]   [2023]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4.19/5.4/5.10 1/1] gfs2: Always check inode size of inline inodes
On Fri, Mar 24, 2023 at 11:26:15PM +0300, Fedor Pchelkin wrote:
> From: Andreas Gruenbacher <agruenba@redhat.com>
>
> commit 70376c7ff31221f1d21db5611d8209e677781d3a upstream.
>
> Check if the inode size of stuffed (inline) inodes is within the allowed
> range when reading inodes from disk (gfs2_dinode_in()). This prevents
> us from on-disk corruption.
>
> The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just
> truncate inline data to the maximum allowed size don't actually make
> sense, and they can be removed now as well.
>
> Reported-by: syzbot+7bb81dfa9cda07d9cd9d@syzkaller.appspotmail.com
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> [pchelkin@ispras.ru: adjust the inode variable inside gfs2_dinode_in with
> the format used before upstream commit 7db354444ad8 ("gfs2: Cosmetic
> gfs2_dinode_{in,out} cleanup")]
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
> ---
> v2: add missed From: tag

Now queued up, thanks.

greg k-h

\
 
 \ /
  Last update: 2023-04-03 15:28    [W:0.097 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site