Messages in this thread | | | Date | Mon, 3 Apr 2023 09:59:08 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 2/3] OPP: Move required opps configuration to specialized callback |
| |
On 01-03-23, 14:06, Ulf Hansson wrote: > On Wed, 22 Feb 2023 at 12:07, Viresh Kumar <viresh.kumar@linaro.org> wrote: > > > > The required-opps configuration is closely tied to genpd and performance > > states at the moment and it is not very obvious that required-opps can > > live without genpds. Though we don't support configuring required-opps > > for non-genpd cases currently. > > > > This commit aims at separating these parts, where configuring genpds > > would be a special case of configuring the required-opps. > > > > Add a specialized callback, set_required_opps(), to the opp table and > > set it to different callbacks accordingly. > > > > This shouldn't result in any functional changes for now. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > This looks reasonable to me, but I guess it also depends on whether > you will land patch3 or not?
Not necessarily, its better to have a clear error path to avoid unnecessary confusion.
I have applied first two patches now. Thanks.
-- viresh
| |