Messages in this thread Patch in this message | | | From | Genjian <> | Subject | [PATCH v2] fix ___SYNC () build error when PROFILE_ALL_BRANCHES is enabled | Date | Thu, 27 Apr 2023 23:03:32 +0800 |
| |
From: Genjian Zhang <zhanggenjian@kylinos.cn>
compiler error (mips-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110):
{standard input}: Assembler messages: {standard input}:171: Error: found '(', expected: ')' {standard input}:171: Error: found '(', expected: ')' {standard input}:171: Error: non-constant expression in ".if" statement {standard input}:171: Error: junk at end of line, first unrecognized character is `('
Expands ___SYNC() macros. However, 'if' statement will be wrong assembly.This Compilers report a lot of errors like the above. this problem is caused by the #define of if() in include/linux/compiler.h when CONFIG_PROFILE_ALL_BRANCHES is set. Move '.if' into quoted strings to fix it.
Reported-by: k2ci <kernel-bot@kylinos.cn> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn> --- arch/mips/include/asm/sync.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/mips/include/asm/sync.h b/arch/mips/include/asm/sync.h index aabd097933fe..56a4f6f6cdef 100644 --- a/arch/mips/include/asm/sync.h +++ b/arch/mips/include/asm/sync.h @@ -175,7 +175,7 @@ */ #ifdef CONFIG_CPU_HAS_SYNC # define ____SYNC(_type, _reason, _else) \ - .if (( _type ) != -1) && ( _reason ); \ + ((_type) != -1) && (_reason); \ .set push; \ .set MIPS_ISA_LEVEL_RAW; \ .rept __SYNC_rpt(_type); \ @@ -192,13 +192,14 @@ /* * Preprocessor magic to expand macros used as arguments before we insert them * into assembly code. + * In addition,'if' cannot be enabled. */ #ifdef __ASSEMBLY__ # define ___SYNC(type, reason, else) \ - ____SYNC(type, reason, else) + .if ____SYNC(type, reason, else) #else # define ___SYNC(type, reason, else) \ - __stringify(____SYNC(type, reason, else)) + ".if" __stringify(____SYNC(type, reason, else)) #endif #define __SYNC(type, reason) \ -- 2.25.1
| |