Messages in this thread | | | Date | Thu, 20 Apr 2023 17:02:19 +0530 | Subject | Re: [PATCH 1/2] dt-bindings: regulator: Add dt property | From | Naresh Solanki <> |
| |
Hi Zev,
On 20-04-2023 04:11 pm, Zev Weiss wrote: > On Thu, Apr 20, 2023 at 01:22:30AM PDT, Naresh Solanki wrote: >> Hi Zev, >> >> On 20-04-2023 05:31 am, Zev Weiss wrote: >>> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote: >>>> Add DT property regulator-supplies. >>>> This enables us to couple one or more regulator output to gether. This >>>> is use in case of Single connector having 2 or more supplies. >>>> >>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >>>> --- >>>> .../bindings/regulator/regulator-output.yaml | 12 +++++++++--- >>>> 1 file changed, 9 insertions(+), 3 deletions(-) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml >>>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml >>>> index 078b37a1a71a..17f683d3c1f3 100644 >>>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml >>>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml >>>> @@ -21,13 +21,19 @@ properties: >>>> compatible: >>>> const: regulator-output >>>> >>>> - vout-supply: >>>> + regulator-supplies: >>>> description: >>>> - Phandle of the regulator supplying the output. >>>> + Specifies the name of the output supply provided by the >>>> regulator. >>>> + Defaults to "vout". >>>> + default: "vout" >>>> + >>> >>> Was this meant to be specified as a string-array to allow providing >>> multiple names? >> Yes. This is string-array. > > Okay -- in that case I think it should include > > $ref: /schemas/types.yaml#/definitions/string-array Ack > >>> >>>> +patternProperties: >>>> + ".*-supply": >>>> + description: >>>> + Specified the phandle for various supplies >>>> >>>> required: >>>> - compatible >>>> - - vout-supply >>>> >>>> additionalProperties: false >>>> >>>> >>> >>> I think it would be nice to also update the examples to show what a >>> multi-supply instance would look like. >> Ack. Will do that. >>> >>> A slightly more descriptive subject line would also be good -- "Add >>> dt property" is a bit vague. >> Suggestion ? >> How about like 'Allow multiple supplies' or 'Add support for multiple >> supplies' > > Sure, both of those sound fine to me. Thanks :) > >>> >>>> base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005 >>>> -- >>>> 2.39.1 >>>> >> Regards, >> Naresh Regards, Naresh
| |