lkml.org 
[lkml]   [2023]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/3] KVM: VMX: Don't rely _only_ on CPUID to enforce XCR0 restrictions for ECREATE
    Date

    > >
    > > Oooh, right. It's not that FP+SSE are always allowed, it's that FP+SSE must always
    > > be _set_. So this?
    > >
    > > xfrm & ~(vcpu->arch.guest_supported_xcr0 | XFEATURE_MASK_FPSSE) ||
    > > (xfrm & XFEATURE_MASK_FPSSE) != XFEATURE_MASK_FPSSE
    >
    > Looks good.
    >
    > I'll try to get some test done with this code change.
    >

    Tested this series with your above code change by running simple SGX app in the
    guest.

    For this particular case, tested with ECREATE with xfrm = 0x1 in the guest, and
    guest can receive #GP.

    So for the entire series:

    Reviewed-by: Kai Huang <kai.huang@intel.com>
    Tested-by: Kai Huang <kai.huang@intel.com>


    >

    \
     
     \ /
      Last update: 2023-04-20 13:00    [W:4.893 / U:2.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site