Messages in this thread | | | Date | Sun, 2 Apr 2023 16:03:38 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH v2 2/3] tools/nolibc: implement fd-based FILE streams |
| |
On Sun, Apr 02, 2023 at 01:02:46PM +0000, Thomas Weißschuh wrote: > Willy: > > This uses intptr_t instead of uintptr_t as proposed because uintptr_t > can not be negative.
Ah yes good point.
> +/* provides the fd from of stream. */ > +static __attribute__((unused)) > +int fileno(FILE *stream) > +{ > + intptr_t i = (intptr_t)stream; > + > + if (i > 0) {
If you don't mind I'll change this to "if (i >= 0)" since we also want to set errno on NULL.
> + SET_ERRNO(EBADF); > + return -1; > + } > + return ~i; > +}
OK for the rest of the series.
Thanks! Willy
| |