lkml.org 
[lkml]   [2023]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] tools/nolibc: implement fd-based FILE streams
On Sun, Apr 02, 2023 at 01:02:46PM +0000, Thomas Weißschuh wrote:
> Willy:
>
> This uses intptr_t instead of uintptr_t as proposed because uintptr_t
> can not be negative.

Ah yes good point.

> +/* provides the fd from of stream. */
> +static __attribute__((unused))
> +int fileno(FILE *stream)
> +{
> + intptr_t i = (intptr_t)stream;
> +
> + if (i > 0) {

If you don't mind I'll change this to "if (i >= 0)" since we also want
to set errno on NULL.


> + SET_ERRNO(EBADF);
> + return -1;
> + }
> + return ~i;
> +}

OK for the rest of the series.

Thanks!
Willy

\
 
 \ /
  Last update: 2023-04-02 16:05    [W:0.060 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site