lkml.org 
[lkml]   [2023]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] Drivers: hv: move panic report code from vmbus to hv early init code
Date
>Subject: Re: [PATCH v2] Drivers: hv: move panic report code from vmbus to hv
>early init code
>
>On Mon, Apr 17, 2023 at 07:28:04PM +0000, Wei Liu wrote:
>> On Sat, Apr 15, 2023 at 06:16:11PM +0000, Michael Kelley (LINUX) wrote:
>> > From: longli@linuxonhyperv.com <longli@linuxonhyperv.com> Sent:
>> > Thursday, April 13, 2023 6:27 PM
>> > >
>> > > The panic reporting code was added in commit 81b18bce48af
>> > > ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V
>> > > during panic")
>> > >
>> > > It was added to the vmbus driver. The panic reporting has no
>> > > dependence on vmbus, and can be enabled at an earlier boot time
>> > > when Hyper-V is initialized.
>> > >
>> > > This patch moves the panic reporting code out of vmbus. There is
>> > > no functionality changes. During moving, also refactored some
>> > > cleanup functions into hv_kmsg_dump_unregister(), and removed
>> > > unused function hv_alloc_hyperv_page().
>> > >
>> > > Signed-off-by: Long Li <longli@microsoft.com>
>> > > ---
>> > >
>> > > Change log v2:
>> > > 1. Check on hv_is_isolation_supported() before reporting crash
>> > > dump 2. Remove hyperv_report_reg(), inline the check condition
>> > > instead 3. Remove the test NULL on hv_panic_page when freeing it
>> > >
>> > > drivers/hv/hv.c | 36 ------
>> > > drivers/hv/hv_common.c | 229
>+++++++++++++++++++++++++++++++++
>> > > drivers/hv/vmbus_drv.c | 199 ----------------------------
>> > > include/asm-generic/mshyperv.h | 1 -
>> > > 4 files changed, 229 insertions(+), 236 deletions(-)
>> >
>> > Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>>
>> Applied to hyperv-next. Thanks.
>
>This broke allmodconfig. I've removed it from the tree. Please fix and resend.
>
>Thanks,
>Wei.

I'm rebasing the patch to latest hyper-v branch, and send v3.

Thanks,
Long

\
 
 \ /
  Last update: 2023-04-19 22:45    [W:0.206 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site