Messages in this thread | | | Date | Mon, 17 Apr 2023 08:22:20 +0200 | Subject | Re: [PATCH V3 3/9] dt-bindings: pinctrl: qcom: Add support for ipq5018 | From | Krzysztof Kozlowski <> |
| |
On 17/04/2023 08:13, Sricharan Ramabadhran wrote: >>> + tlmm: pinctrl@1000000 { >>> + compatible = "qcom,ipq5018-tlmm"; >>> + reg = <0x01000000 0x300000>; >>> + gpio-controller; >>> + #gpio-cells = <2>; >>> + gpio-ranges = <&tlmm 0 0 47>; >>> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; >>> + interrupt-controller; >>> + #interrupt-cells = <2>; >>> + >>> + uart2-state { >>> + pins = "gpio34", "gpio35"; >>> + function = "blsp2_uart"; >> >> Does not look like you tested the bindings. Please run `make >> dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). > > I ran it against the TOT, will run it this time on nxt and post V4.
I don't know what is TOT, but this would fail in every case on every tree.
Best regards, Krzysztof
| |