Messages in this thread | | | From | "Gupta, Nipun" <> | Subject | RE: [PATCH v2] vfio/cdx: add support for CDX bus | Date | Mon, 17 Apr 2023 13:21:20 +0000 |
| |
[AMD Official Use Only - General]
> -----Original Message----- > From: Jason Gunthorpe <jgg@ziepe.ca> > Sent: Monday, April 17, 2023 6:49 PM > To: Alex Williamson <alex.williamson@redhat.com> > Cc: Gupta, Nipun <Nipun.Gupta@amd.com>; linux-kernel@vger.kernel.org; > kvm@vger.kernel.org; masahiroy@kernel.org; nathan@kernel.org; > ndesaulniers@google.com; nicolas@fjasle.eu; git (AMD-Xilinx) <git@amd.com>; > Anand, Harpreet <harpreet.anand@amd.com>; Jansen Van Vuuren, Pieter > <pieter.jansen-van-vuuren@amd.com>; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com> > Subject: Re: [PATCH v2] vfio/cdx: add support for CDX bus > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Fri, Apr 14, 2023 at 03:36:14PM -0600, Alex Williamson wrote: > > > > +static int vfio_cdx_init_device(struct vfio_device *core_vdev) > > > +{ > > > + struct vfio_cdx_device *vdev = > > > + container_of(core_vdev, struct vfio_cdx_device, vdev); > > > + struct cdx_device *cdx_dev = to_cdx_device(core_vdev->dev); > > > + > > > + vdev->cdx_dev = cdx_dev; > > > + vdev->dev = &cdx_dev->dev; > > > > Both of these seem trivial to factor out of this patch, cdx_device is > > always available via to_cdx_device(core_vdev->dev) and the struct > > device is always available via core_vdev->dev. vdev->dev isn't even > > used anywhere yet. Both the init and release functions here could be > > dropped afaict. > > Yes please, I have a series someplace that gets rid of all these > redundent ->devs we keep around everwhere. > > to_cdx_device(core_vdev->dev) is a good solution, maybe with a static > inline.
Agree, we have already rolled out v3 which has this change i.e using to_cdx_dev(core_vdev->dev) instead of storing these again.
Thanks, Nipun
> > Jason
| |