Messages in this thread | | | From | Akinobu Mita <> | Date | Sun, 16 Apr 2023 01:50:47 +0900 | Subject | Re: [PATCH 1/2] fault-inject: allow configuration via configfs |
| |
2023年4月15日(土) 23:53 Geert Uytterhoeven <geert@linux-m68k.org>: > > Hi Mita-san, > > On Mon, Mar 27, 2023 at 4:48 PM Akinobu Mita <akinobu.mita@gmail.com> wrote: > > This provides a helper function to allow configuration of fault-injection > > for configfs-based drivers. > > > > The config items created by this function have the same interface as the > > one created under debugfs by fault_create_debugfs_attr(). > > > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > > Thanks for your patch, which is now commit 4668c7a2940d134b > ("fault-inject: allow configuration via configfs") in linux-next > (to be tagged soon as next-20140414). > > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1977,9 +1977,20 @@ config FAIL_SUNRPC > > Provide fault-injection capability for SunRPC and > > its consumers. > > > > +config FAULT_INJECTION_CONFIGFS > > + bool "Configfs interface for fault-injection capabilities" > > + depends on FAULT_INJECTION && CONFIGFS_FS > > noreply@ellerman.id.au reported build failures for e.g. m68k-allmodconfig > http://kisskb.ellerman.id.au/kisskb/buildresult/14911188/: > > fault-inject.c:(.text+0x1ee): undefined reference to > `config_group_init_type_name' > > This fails because FAULT_INJECTION=y but CONFIGFS_FS=m.
Oh, I just sent that build fix patch. https://lore.kernel.org/all/20230415125705.180426-1-akinobu.mita@gmail.com/
Could you please check if this is the correct way to fix it?
| |