Messages in this thread | | | Date | Fri, 14 Apr 2023 08:29:26 -0700 | Subject | Re: [PATCH v3] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS | From | Randy Dunlap <> |
| |
On 4/14/23 06:55, Johannes Berg wrote: > On Sun, 2023-04-09 at 18:13 -0700, Randy Dunlap wrote: >> Current build of pata_cs5536 for i386 UML fails with: >> >> ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! >> ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! >> ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! >> ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! >> >> Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. >> > > Hm. Does this make sense? I can't see it'd work on UML to configure an > IDE device through MSRs? Surely that can't work? IOW, that entire driver > can't really work anyway can it? > > OTOH, maybe theoretically it could work in PCI, just not with MSRs, and > then this patch makes some sense?
Hi, I was happy with v1, which just did "depends on !UML". Anyway, I'll drop this part of the quest to make UML build cleanly.
Thanks. -- ~Randy
| |