Messages in this thread | | | Date | Fri, 14 Apr 2023 12:01:07 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to info level |
| |
On Fri, Apr 14, 2023 at 10:46:19AM +0200, Johan Hovold wrote: > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to info level and clearly mark it as a firmware bug: > > psci: [Firmware Bug]: failed to set PC mode: -3 > > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > Acked-by: Mark Rutland <mark.rutland@arm.com> > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > > This one fell between the cracks so resending with tags added. > > Mark or Lorenzo, is this something you can pick up? > > Johan
Sorry about this.
I don't think we have anything else in this area, so Arnd, are you happy to pick this via the soc tree?
Thanks, Mark.
> > > drivers/firmware/psci/psci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 29619f49873a..d9629ff87861 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_info(FW_BUG "failed to set %s mode: %d\n", > + enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > } > > -- > 2.39.2 >
| |