Messages in this thread | | | Date | Fri, 14 Apr 2023 17:10:27 -0700 | Subject | Re: [PATCH v2] drm/msm/dpu: always program dsc active bits | From | Abhinav Kumar <> |
| |
On 4/14/2023 3:52 PM, Marijn Suijten wrote: > On 2023-04-14 14:03:23, Abhinav Kumar wrote: > [..] >>>> Yes, ofcourse git send-email was used to send the patch, not any other >>>> mail client. >>>> >>>> Yes i am also aware that send-email converts rb to CC. >>>> >>>> But if you keep working on the local branch, then you would have to >>>> manually add the r-bs. If you use am of the prev version and develop on >>>> that, it will automatically add the r-bs. > > I don't think git-am is smart enough to fetch additional replies from > lore and apply the reviewed-by (and other trailers). This workflow > relies on downloading the mbox from a service that extracts and > accumulates the trailers such as patchwork, see for example: > > https://patchwork.freedesktop.org/api/1.0/series/116340/revisions/1/mbox/ > > Note that it also picked up one sentence starting with Fixes: > > Fixes: tag below seems extraneous. >
Yes, I usually use git-pw ap.
So perhaps, I should have been more specific to say that.
Some form of am is what i wanted to emphasize but just wrote git am by mistake.
> On the other hand b4 (shaz)am is itself capable of downloading the whole > mail thread and appending all trailers, just like patchwork is doing > above, in one automated `b4 shazam <lore link>` command. > > And to solve the problem of trailers arriving in your inbox after > working on the next revision in a local branch - or without ever even > redownloading the series from lore/patchwork¸ b4 has a command to > download and apply them to commits in your local branch: > > b4 trailers -uF <lore link> > > Try it out, b4 is amazing :) >
Yes, i recently started using it to send "applied" emails as suggested by Dmitry , for patch related work was still using git-pw.
Perhaps, I will switch completely to it.
> [..] >> 2) I synced with kuogee. his git version seems to be quite old which is >> not adding the folks from r-b to cc. So there was nothing wrong with >> invocation, just versioning. > > You are right. The X-Mailer header of Kuogee's patch indicates git > 2.7.4, while cc'ing of additional -by trailers (such as r-b's) was only > introduced in 2.20.0: > > https://github.com/git/git/commit/ef0cc1df90f6b6c2987ab2db8e0ccf2cfc421edf > > Fwiw 2.7.4 is from March 2016. > > - Marijn
| |