Messages in this thread | | | Date | Tue, 11 Apr 2023 18:49:52 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net/bridge: add drop reasons for bridge forwarding |
| |
On Wed, 12 Apr 2023 09:33:10 +0800 xu xin wrote: > >You can return the reason from this function. That's the whole point of > >SKB_NOT_DROPPED_YET existing and being equal to 0. > > If returning the reasons, then the funtion will have to be renamed because > 'should_deliever()' is expected to return a non-zero value when it's ok to > deliever. I don't want to change the name here, and it's better to keep its > name and use the pointer to store the reasons.
Sure. You have to touch all callers, anyway, you can as well adjust the name.
| |