Messages in this thread | | | Date | Tue, 11 Apr 2023 19:07:20 +0200 | Subject | Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous "input-enable" | From | Krzysztof Kozlowski <> |
| |
On 11/04/2023 16:12, Johan Hovold wrote: > On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote: >> Pin configuration property "input-enable" was used with the intention to >> disable the output, but this is done by default by Linux drivers. Since >> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not >> input-enable") the property is not accepted anymore. > > This description does not seem to match the pin configurations that you > are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl" > binding for which 'input-enable' is still accepted AFAICT. > > Perhaps you can fix up the lpass bindings (and driver?) to match?
Thanks for spotting this. This change is wrong.
Best regards, Krzysztof
| |