Messages in this thread | | | From | Sai Krishna Gajula <> | Subject | Re: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field hash extract | Date | Mon, 10 Apr 2023 08:43:51 +0000 |
| |
Please see inline,
> -----Original Message----- > From: Simon Horman <simon.horman@corigine.com> > Sent: Saturday, April 8, 2023 8:51 PM > To: Sai Krishna Gajula <saikrishnag@marvell.com> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>; > Geethasowjanya Akula <gakula@marvell.com>; richardcochran@gmail.com; > Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran > <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; > Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Ratheesh Kannoth > <rkannoth@marvell.com> > Subject: Re: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field > hash extract > > On Fri, Apr 07, 2023 at 05:53:42PM +0530, Sai Krishna wrote: > > From: Ratheesh Kannoth <rkannoth@marvell.com> > > > > 1. As per previous implementation, mask and control parameter to > > generate the field hash value was not passed to the caller program. > > Updated the secret key mbox to share that information as well, as a > > part of the fix. > > 2. Earlier implementation did not consider hash reduction of both > > source and destination IPv6 addresses. Only source IPv6 address was > > considered. This fix solves that and provides option to hash reduce > > both source and destination IPv6 addresses. > > 3. Fix endianness issue during hash reduction while storing the IPv6 > > source/destination address as hash keys. > > 4. Configure hardware parser based on hash extract feature enable flag > > for IPv6. > > Hi Sai and Ratheesh, > > there is a lot going on here. > Could you consider breaking this up into more than one patch?
We will break this patch into multiple patches and submit v3.
Thanks, Sai
| |