lkml.org 
[lkml]   [2023]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 22/28] ASoC: qcom: qdsp6: q6afe: Split USB AFE dev_token param into separate API
From
Hi Srinivas,

On 3/9/2023 1:01 AM, Srinivas Kandagatla wrote:
>
>
> On 08/03/2023 23:57, Wesley Cheng wrote:
>> The Q6USB backend can carry information about the available USB SND cards
>> and PCM devices discovered on the USB bus.  The dev_token field is
>> used by
>> the audio DSP to notify the USB offload driver of which card and PCM
>> index
>> to enable playback on.  Separate this into a dedicated API, so the USB
>> backend can set the dev_token accordingly.  The audio DSP does not
>> utilize
>> this information until the AFE port start command is sent, which is done
>> during the PCM prepare phase.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>> ---
>>   sound/soc/qcom/qdsp6/q6afe.c | 49 +++++++++++++++++++++++++-----------
>>   sound/soc/qcom/qdsp6/q6afe.h |  1 +
>>   2 files changed, 36 insertions(+), 14 deletions(-)
>>
> Looks like this could be part of [06/28] ASoC: qcom: qdsp6: Introduce
> USB AFE port to q6dsp
>
> you are modifying the 06/28 patch in this patch.
>
> other than that it looks fine to me.
>

Sure I'll squash the two.

Thanks
Wesley Cheng

\
 
 \ /
  Last update: 2023-03-27 00:52    [W:0.148 / U:1.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site