Messages in this thread | | | Date | Wed, 8 Mar 2023 17:09:47 +0100 | Subject | Re: [PATCH v1 03/25] arm64: dts: colibri-imx8x: Sort properties | From | Krzysztof Kozlowski <> |
| |
On 08/03/2023 15:50, Philippe Schenker wrote: > On Wed, 2023-03-08 at 15:32 +0100, Krzysztof Kozlowski wrote: >> On 08/03/2023 14:29, Philippe Schenker wrote: >>> On Wed, 2023-03-08 at 13:57 +0100, Krzysztof Kozlowski wrote: >>>> Is this approved coding style for IMX DTS? >>> >>> How the ordering should be done is nowhere specifically documented >>> (at >>> least this is my current understanding). >>> The ordering how I noted it is what we gathered from multiple >>> feedback >>> on mailinglist discussions. >>> >>> With that ordering I hope everyone is happy. >>> >>> Philippe >> >> Yeah, but what if next developer next month re-orders all your nodes >> again because he will use different coding style? > > Someone from Toradex will complain that we want to have it the way I > sent now, since this is the way we agreed on internally.
I am sorry, but coding style is per subsystem, not per Toradex boards. Even if my example is not applicable, someone might come soon with something different for entire iMX and again re-order it.
Either make a rule for entire iMX or do not make re-shufflings. They are not useful.
Best regards, Krzysztof
| |