lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH linux-next v2 3/3] drivers/platform/x86/intel: fix a memory leak in intel_vsec_add_aux
    Date
    The first error handling code in intel_vsec_add_aux misses the
    deallocation of intel_vsec_dev->resource.

    Fix this by adding kfree(intel_vsec_dev->resource) in the error handling
    code.

    Reviewed-by: David E. Box <david.e.box@linux.intel.com>
    Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
    ---
    drivers/platform/x86/intel/vsec.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
    index 13decf36c6de..2311c16cb975 100644
    --- a/drivers/platform/x86/intel/vsec.c
    +++ b/drivers/platform/x86/intel/vsec.c
    @@ -154,6 +154,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
    ret = ida_alloc(intel_vsec_dev->ida, GFP_KERNEL);
    mutex_unlock(&vsec_ida_lock);
    if (ret < 0) {
    + kfree(intel_vsec_dev->resource);
    kfree(intel_vsec_dev);
    return ret;
    }
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-03-27 00:51    [W:5.772 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site