Messages in this thread | | | From | Ondrej Zary <> | Subject | Re: [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 | Date | Wed, 8 Mar 2023 23:48:29 +0100 |
| |
On Wednesday 08 March 2023 21:01:09 Luis Chamberlain wrote: > On Wed, Mar 08, 2023 at 09:07:07PM +0800, Baoquan He wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > > extension, and on ia64 with its slightly unconventional ioremap() > > behavior, everywhere else this is the same as ioremap() anyway. > > > > Change the only driver that still references ioremap_uc() to only do so > > on x86-32/ia64 in order to allow removing that interface at some > > point in the future for the other architectures. > > > > On some architectures, ioremap_uc() just returns NULL, changing > > the driver to call ioremap() means that they now have a chance > > of working correctly. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Baoquan He <bhe@redhat.com> > > Cc: Helge Deller <deller@gmx.de> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > > Cc: linux-fbdev@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> > > Is anyone using this driver these days? How often do fbdev drivers get > audited to see what can be nuked?
Older servers have integrated ATI Rage XL chips and this is the only driver for it.
-- Ondrej Zary
| |