Messages in this thread | | | Date | Thu, 9 Mar 2023 00:22:55 +0300 | Subject | Re: [PATCH 17/20] dt-bindings: pinctrl: mediatek: mt7986: fix patternProperties regex | From | Arınç ÜNAL <> |
| |
On 9.03.2023 00:15, Rob Herring wrote: > On Fri, Mar 03, 2023 at 03:28:46AM +0300, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> Set second level patternProperties to '^.*mux.*$' and '^.*conf.*$' on >> mediatek,mt7986-pinctrl.yaml. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> --- >> .../devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml >> index 46b7228920ed..e937881210c5 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml >> @@ -72,7 +72,7 @@ patternProperties: >> additionalProperties: false >> >> patternProperties: >> - '.*mux.*': >> + '^.*mux.*$': > > These are equivalent (so is just 'mux', but that's ambiguous). Why are > we changing them? Ideally, we'd only have a wildcard on one end.
I've seen your review on Daniel's patch for adding mt7981 pinctrl schema so I wanted other schemas to be on par with your review.
https://lore.kernel.org/linux-mediatek/20230123225943.GA2781371-robh@kernel.org/
Arınç
| |