lkml.org 
[lkml]   [2023]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH v1 3/4] ufs: mcq: Add support for clean up mcq resources
From
On 3/7/23 20:01, Bao D. Nguyen wrote:
> static int ufshcd_clear_cmds(struct ufs_hba *hba, u32 mask)
> {
> unsigned long flags;
> + int err, result, tag;
>
> + if (is_mcq_enabled(hba)) {
> + /*
> + * MCQ mode. Clean up the MCQ resources similar to
> + * what the ufshcd_utrl_clear() does for SDB mode.
> + */
> + flags = (unsigned long)mask;
> + for_each_set_bit(tag, &flags, hba->nutrs) {
> + err = ufshcd_mcq_sq_cleanup(hba, tag, &result);
> + if (err || result) {
> + dev_err(hba->dev, "%s: failed tag=%d. err=%d, result=%d\n",
> + __func__, tag, err, result);
> + return FAILED;
> + }
> + }
> + return 0;
> + }

Please change the type of the 'mask' argument from u32 into unsigned
long such that the assignment of 'mask' to 'flags' can be removed.

Thanks,

Bart.

\
 
 \ /
  Last update: 2023-03-27 00:50    [W:0.042 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site