lkml.org 
[lkml]   [2023]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 09/11] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd
    From
    On 07/03/2023 05:41, Manikanta Mylavarapu wrote:
    > Enable nodes required for multipd remoteproc bring up
    >
    > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
    > ---
    > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 130 ++++++++++++++++++++++++++
    > 1 file changed, 130 insertions(+)
    > soc: soc@0 {
    > #address-cells = <1>;
    > #size-cells = <1>;
    > @@ -217,5 +259,93 @@ frame@b128000 {
    > status = "disabled";
    > };
    > };
    > +
    > + tcsr_mutex: hwlock@1905000 {

    This does not look like in correct order. Don't stuff things to the end
    of lists.

    > + compatible = "qcom,tcsr-mutex";
    > + reg = <0x01905000 0x8000>;
    > + #hwlock-cells = <1>;
    > + };
    > +
    > + apcs_glb: mailbox@b111000 {
    > + compatible = "qcom,ipq5018-apcs-apps-global";
    > + reg = <0x0b111000 0x1000>;
    > + #clock-cells = <1>;
    > + #mbox-cells = <1>;
    > + };
    > +
    > + q6v5_wcss: remoteproc@cd00000 {
    > + compatible = "qcom,ipq5018-q6-mpd";
    > + #address-cells = <1>;
    > + #size-cells = <1>;
    > + ranges;
    > + reg = <0x0cd00000 0x4040>;
    > + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>,
    > + <&wcss_smp2p_in 0 0>,
    > + <&wcss_smp2p_in 1 0>,
    > + <&wcss_smp2p_in 2 0>,
    > + <&wcss_smp2p_in 3 0>;
    > + interrupt-names = "wdog",
    > + "fatal",
    > + "ready",
    > + "handover",
    > + "stop-ack";
    > +
    > + qcom,smem-states = <&wcss_smp2p_out 0>,
    > + <&wcss_smp2p_out 1>;
    > + qcom,smem-state-names = "shutdown",
    > + "stop";
    > + memory-region = <&q6_region>;
    > +
    > + glink-edge {
    > + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>;
    > + label = "rtr";
    > + qcom,remote-pid = <1>;
    > + mboxes = <&apcs_glb 8>;
    > + };
    > +
    > + q6_wcss_pd1: remoteproc_pd1 {

    No underscores in node names, generic node names. Actually I don't get
    why do you need empty node at all.

    > + compatible = "qcom,ipq5018-wcss-ahb-mpd";
    > + };
    > +
    > + q6_wcss_pd2: remoteproc_pd2 {
    > + compatible = "qcom,ipq5018-wcss-pcie-mpd";
    > + interrupts-extended = <&wcss_smp2p_in 16 0>,
    > + <&wcss_smp2p_in 17 0>,
    > + <&wcss_smp2p_in 20 0>,
    > + <&wcss_smp2p_in 19 0>;


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-03-27 00:47    [W:2.182 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site