Messages in this thread | | | Date | Tue, 7 Mar 2023 11:44:03 +0100 | Subject | Re: [PATCH v7 21/41] mm: Add guard pages around a shadow stack. | From | David Hildenbrand <> |
| |
On 07.03.23 11:32, Borislav Petkov wrote: > On Tue, Mar 07, 2023 at 01:29:50AM +0000, Edgecombe, Rick P wrote: >> On Mon, 2023-03-06 at 09:08 +0100, Borislav Petkov wrote: >>> Just typos: >> >> All seem reasonable to me. Thanks. >> >> For using the log verbiage for the comment, it is quite big. Does >> something like this seem reasonable? > > Yeah, it does. I wouldn't want to lose that explanation in a commit > message. > > However, this special aspect pertains to the shstk implementation in x86 > but the code is generic mm and such arch-specific comments are kinda > unfitting there. > > I wonder if it would be better if you could stick that explanation > somewhere in arch/x86/ and only refer to it in a short comment above > VM_SHADOW_STACK check in stack_guard_start_gap()...
+1
-- Thanks,
David / dhildenb
| |