Messages in this thread | | | From | Nadav Amit <> | Subject | Re: [PATCH v3 3/5] mm: userfaultfd: combine 'mode' and 'wp_copy' arguments | Date | Tue, 7 Mar 2023 01:54:59 +0000 |
| |
Excluding Peter’s comments, LGTM.
> On Mar 6, 2023, at 2:50 PM, Axel Rasmussen <axelrasmussen@google.com> wrote: > > @@ -131,8 +131,8 @@ static int mfill_atomic_pte_copy(pmd_t *dst_pmd, > struct vm_area_struct *dst_vma, > unsigned long dst_addr, > unsigned long src_addr, > - struct page **pagep, > - bool wp_copy) > + uffd_flags_t flags, > + struct page **pagep)
Yet, it would be nice if we can be consistent on whether pagep precedes flags or not (it’s the other way around in shmem_mfill_atomic_pte()).
| |