Messages in this thread | | | Subject | Re: [PATCH] scsi: hisi_sas: add a check of devm_add_action | From | "chenxiang (M)" <> | Date | Mon, 6 Mar 2023 11:06:56 +0800 |
| |
Hi,
在 2023/2/27 11:10, void0red 写道: > From: Kang Chen <void0red@gmail.com> > > devm_add_action may fails, check it in the caller of > interrupt_preinit_v3_hw > > Signed-off-by: Kang Chen <void0red@gmail.com>
Acked-by: Xiang Chen <chenxiang66@hisilicon.com> Thanks!
> --- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c > index 0c3fcb807..a63279f55 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c > @@ -2495,8 +2495,7 @@ static int interrupt_preinit_v3_hw(struct hisi_hba *hisi_hba) > hisi_hba->cq_nvecs = vectors - BASE_VECTORS_V3_HW; > shost->nr_hw_queues = hisi_hba->cq_nvecs; > > - devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev); > - return 0; > + return devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev); > } > > static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)
| |