lkml.org 
[lkml]   [2023]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function
From
On 30/03/2023 04:13, Leo Yan wrote:
> On Wed, Mar 29, 2023 at 07:14:52PM -0300, Arnaldo Carvalho de Melo wrote:
>
> [...]
>
>>> Not here, I'll check after a call:
>>>
>>> 50 9.90 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
>>> arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header':
>>> arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration]
>>> data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu);
>>> ^~~~~~~~~~~~~~~~~~~~~~
>>
>> This function was removed in:
>>
>> Author: Mike Leach <mike.leach@linaro.org>
>> Date: Wed Mar 29 12:14:21 2023 +0100
>>
>> perf cs-etm: Update record event to use new Trace ID protocol
>>
>> Trace IDs are now dynamically allocated.
>>
>> I'm removing this series from perf-tools-next, please address this issue
>> and send a v9.
>
> I can reproduce this building failure. I am curious for how to verify
> building for patch wise, the link [1] gives me some hints and below
> command works for me:
>
> $ git rebase -i --exec "make -C tools/perf clean && \
> make -C tools/perf VF=1 DEBUG=1 CORESIGHT=1 && \
> make -C tools/perf clean && \
> make -C tools/perf VF=1 DEBUG=1" HEAD~3

Looks like perf-tools-next has some changes that has not reflected
elsewhere. The ts_source patches are queued there, which is causing
the above build failure.

Mike,

Are you able to rebase your patches on perf-tools-next branch ?

Kind regards
Suzuki

>
> Thanks,
> Leo
>
> [1] https://stackoverflow.com/questions/26983700/git-run-shell-command-for-each-commit

\
 
 \ /
  Last update: 2023-03-30 12:56    [W:0.056 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site