lkml.org 
[lkml]   [2023]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net v2 0/3] fix header length on skb merging
From
Date
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 28 Mar 2023 14:30:10 +0300 you wrote:
> Hello,
>
> this patchset fixes appending newly arrived skbuff to the last skbuff of
> the socket's queue during rx path. Problem fires when we are trying to
> append data to skbuff which was already processed in dequeue callback
> at least once. Dequeue callback calls function 'skb_pull()' which changes
> 'skb->len'. In current implementation 'skb->len' is used to update length
> in header of last skbuff after new data was copied to it. This is bug,
> because value in header is used to calculate 'rx_bytes'/'fwd_cnt' and
> thus must be constant during skbuff lifetime. Here is example, we have
> two skbuffs: skb0 with length 10 and skb1 with length 4.
>
> [...]

Here is the summary with links:
- [net,v2,1/3] virtio/vsock: fix header length on skb merging
https://git.kernel.org/netdev/net/c/f7154d967bc4
- [net,v2,2/3] virtio/vsock: WARN_ONCE() for invalid state of socket
https://git.kernel.org/netdev/net/c/b8d2f61fdf2a
- [net,v2,3/3] test/vsock: new skbuff appending test
https://git.kernel.org/netdev/net/c/25209a3209ec

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


\
 
 \ /
  Last update: 2023-03-30 11:11    [W:0.043 / U:1.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site