Messages in this thread | | | Date | Fri, 3 Mar 2023 10:01:38 -0800 | Subject | Re: [PATCH v4] scsi: ufs: core: Add trace event for MCQ | From | Bart Van Assche <> |
| |
On 3/3/23 01:35, Ziqi Chen wrote: > - doorbell = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL); > - trace_ufshcd_command(dev_name(hba->dev), str_t, tag, > - doorbell, transfer_len, intr, lba, opcode, group_id); > + > + if (is_mcq_enabled(hba)) { > + hwq = ufshcd_mcq_req_to_hwq(hba, rq); > + trace_ufshcd_command_mcq(dev_name(hba->dev), str_t, tag, > + hwq, transfer_len, intr, lba, opcode, group_id); > + } else { > + doorbell = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL); > + trace_ufshcd_command(dev_name(hba->dev), str_t, tag, > + doorbell, transfer_len, intr, lba, opcode, group_id); > + } > } Users will hate it if the trace events for legacy mode and MCQ mode are different. Instead of defining a new trace event for the MCQ mode, I think we need to add the MCQ information in the existing trace event.
Thanks,
Bart.
| |