Messages in this thread | | | Subject | Re: [PING PATCH v4 27/29] LoongArch: KVM: Implement vcpu world switch | From | Tianrui Zhao <> | Date | Thu, 30 Mar 2023 11:41:35 +0800 |
| |
在 2023年03月28日 22:13, Paolo Bonzini 写道: > On 3/28/23 14:31, Tianrui Zhao wrote: >> + * prepare switch to guest >> + * @param: >> + * KVM_ARCH: kvm_vcpu_arch, don't touch it until 'ertn' >> + * GPRNUM: KVM_ARCH gpr number > > Stale comment (should be "a2: kvm_vcpu_arch, don't touch it until > 'ertn'"). > > Since you are at it, I noticed now that tmp and tmp1 aren't too useful > because all registers will be overwritten before the end of the macro. > You choose whether to keep or remove them. > > Paolo
Thanks, I will fix the stale comment and remove the tmp,tmp1 argument and replace it with t0,t1 reg.
Thanks Tianrui Zhao
> >> + * tmp, tmp1: temp register >> + */
| |