Messages in this thread | | | Date | Tue, 28 Mar 2023 12:48:59 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table |
| |
Hi Krzysztof,
krzysztof.kozlowski@linaro.org wrote on Sat, 11 Mar 2023 18:32:58 +0100:
> The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). > > drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I see Stefan already acked most of the ieee802154 patches, but I didn't got notified for this one, so in case:
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> --- > drivers/net/ieee802154/adf7242.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > index 5cf218c674a5..509acc86001c 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id); > static struct spi_driver adf7242_driver = { > .id_table = adf7242_device_id, > .driver = { > - .of_match_table = of_match_ptr(adf7242_of_match), > + .of_match_table = adf7242_of_match, > .name = "adf7242", > .owner = THIS_MODULE, > },
Thanks, Miquèl
| |