lkml.org 
[lkml]   [2023]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v1 4/4] clk: qcom: lpasscc-sc7280: Remove qdsp6ss clock registration
    From
    Date
    Quoting Mohammad Rafi Shaik (2023-03-27 09:32:49)
    > diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.c
    > index 48432010ce24..4719e3fa8b05 100644
    > --- a/drivers/clk/qcom/lpasscc-sc7280.c
    > +++ b/drivers/clk/qcom/lpasscc-sc7280.c
    > @@ -121,17 +67,10 @@ static int lpass_cc_sc7280_probe(struct platform_device *pdev)
    > goto destroy_pm_clk;
    > }
    >
    > - lpass_regmap_config.name = "qdsp6ss";
    > - desc = &lpass_qdsp6ss_sc7280_desc;
    > -
    > - ret = qcom_cc_probe_by_index(pdev, 0, desc);
    > - if (ret)
    > - goto destroy_pm_clk;
    > -
    > lpass_regmap_config.name = "top_cc";
    > desc = &lpass_cc_top_sc7280_desc;
    >
    > - ret = qcom_cc_probe_by_index(pdev, 1, desc);
    > + ret = qcom_cc_probe_by_index(pdev, 0, desc);

    Instead of changing the binding, it may be better to leave it as is and
    ignore the first reg property in the driver. Then you don't need any DTS
    patch or binding patch. You can just have this one patch. After that you
    can introduce a new compatible string for the proper design and make it
    have only a single reg property and deprecate the old binding. The
    driver can then pick index 0 if the new compatible is present.

    \
     
     \ /
      Last update: 2023-03-29 05:11    [W:2.925 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site