lkml.org 
[lkml]   [2023]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] blktrace: Gracefully return if fail in blk_register_tracepoints()
Date
On 3/28/23 02:46, Zheng Yejian wrote:
> Currently blk_register_tracepoints() WARN for every registration failure
> of block tracepoint, however, blk_trace can still be setup-ed.
>
> It seems better to cleanup registered tracepoints and return error when
> a certain registration failed, even if it's a small probability, and
> users can know the error and do blk_trace setup again.
>
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
>

So far I'm fine with current code as this adds a lot of code.
I've thought of doing this when I worked on blktrace extension, but
others are okay with it sure ..

-ck


\
 
 \ /
  Last update: 2023-03-28 19:59    [W:0.039 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site