lkml.org 
[lkml]   [2023]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 4/7] mfd: ocelot-spi: Change the regmap stride to reflect the real one
> > >  static const struct regmap_config ocelot_spi_regmap_config = {
> > > .reg_bits = 24,
> > > - .reg_stride = 4,
> > > + .reg_stride = 1,
> > > .reg_shift = REGMAP_DOWNSHIFT(2),
> > > .val_bits = 32,
> >
> > This does not look like a bisectable change? Or did it never work
> > before?
>
> Actually this works in all cases because of "regmap: check for alignment
> on translated register addresses" in this series. Before this series,
> I think using a stride of 1 would have worked too, as any 4-byte-aligned
> accesses are also 1-byte aligned.

This is the sort of think which is good to explain in the commit
message. That is the place to answer questions reviewers are likely to
ask for things which are not obvious from just the patch.

Andrew

\
 
 \ /
  Last update: 2023-03-27 02:04    [W:0.111 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site