lkml.org 
[lkml]   [2023]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH RESEND] firmware: turris-mox-rwtm: make kobj_type structure constant
Didn't I already give reviewed-by tag?

Reviewed-by: Marek Behún <kabel@kernel.org>

On Fri, Mar 24, 2023 at 04:27:50PM +0000, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/firmware/turris-mox-rwtm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 6ea5789a89e2..2de0fb139ce1 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -104,7 +104,7 @@ static void mox_kobj_release(struct kobject *kobj)
> kfree(to_rwtm(kobj)->kobj);
> }
>
> -static struct kobj_type mox_kobj_ktype = {
> +static const struct kobj_type mox_kobj_ktype = {
> .release = mox_kobj_release,
> .sysfs_ops = &kobj_sysfs_ops,
> };
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-firmware-turris-6cd4a66bac19
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>

\
 
 \ /
  Last update: 2023-03-27 01:17    [W:0.041 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site