lkml.org 
[lkml]   [2023]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 04/14] extcon: use sysfs_emit() to instead of sprintf()
    Date
    Follow the advice of the Documentation/filesystems/sysfs.rst that
    show() should only use sysfs_emit() or sysfs_emit_at() when formatting
    the value to be returned to user space.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/extcon/extcon.c | 18 +++++++++---------
    1 file changed, 9 insertions(+), 9 deletions(-)

    diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
    index 70e9755ba2bc..ac84f4aafc69 100644
    --- a/drivers/extcon/extcon.c
    +++ b/drivers/extcon/extcon.c
    @@ -370,12 +370,12 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
    struct extcon_dev *edev = dev_get_drvdata(dev);

    if (edev->max_supported == 0)
    - return sprintf(buf, "%u\n", edev->state);
    + return sysfs_emit(buf, "%u\n", edev->state);

    for (i = 0; i < edev->max_supported; i++) {
    - count += sprintf(buf + count, "%s=%d\n",
    - extcon_info[edev->supported_cable[i]].name,
    - !!(edev->state & BIT(i)));
    + count += sysfs_emit_at(buf, count, "%s=%d\n",
    + extcon_info[edev->supported_cable[i]].name,
    + !!(edev->state & BIT(i)));
    }

    return count;
    @@ -387,7 +387,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
    {
    struct extcon_dev *edev = dev_get_drvdata(dev);

    - return sprintf(buf, "%s\n", edev->name);
    + return sysfs_emit(buf, "%s\n", edev->name);
    }
    static DEVICE_ATTR_RO(name);

    @@ -398,8 +398,8 @@ static ssize_t cable_name_show(struct device *dev,
    attr_name);
    int i = cable->cable_index;

    - return sprintf(buf, "%s\n",
    - extcon_info[cable->edev->supported_cable[i]].name);
    + return sysfs_emit(buf, "%s\n",
    + extcon_info[cable->edev->supported_cable[i]].name);
    }

    static ssize_t cable_state_show(struct device *dev,
    @@ -410,8 +410,8 @@ static ssize_t cable_state_show(struct device *dev,

    int i = cable->cable_index;

    - return sprintf(buf, "%d\n",
    - extcon_get_state(cable->edev, cable->edev->supported_cable[i]));
    + return sysfs_emit(buf, "%d\n",
    + extcon_get_state(cable->edev, cable->edev->supported_cable[i]));
    }

    /**
    --
    2.40.0.1.gaa8946217a0b
    \
     
     \ /
      Last update: 2023-03-27 01:12    [W:4.091 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site