lkml.org 
[lkml]   [2023]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer
From
Hi Rob,

On 2023/03/20 2:30, Rob Herring wrote:
> Add support for Socionext Synquacer SDHCI. This binding has been in use
> for
> some time.
>
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Surely "interrupts" is needed. The 2nd interrupt seems to come from
the card, though, the driver isn't supported it.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thank you,

>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Rebase on conversion done by Kunihiko
> ---
> .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> index 73d747e917f3..430b62899397 100644
> --- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> @@ -14,9 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - fujitsu,mb86s70-sdhci-3.0
> - - socionext,f-sdh30-e51-mmc
> + oneOf:
> + - items:
> + - const: socionext,synquacer-sdhci
> + - const: fujitsu,mb86s70-sdhci-3.0
> + - enum:
> + - fujitsu,mb86s70-sdhci-3.0
> + - socionext,f-sdh30-e51-mmc
>
> reg:
> maxItems: 1
> @@ -29,6 +33,11 @@ properties:
> - const: iface
> - const: core
>
> + dma-coherent: true
> +
> + interrupts:
> + maxItems: 2
> +
> resets:
> maxItems: 1
>


---
Best Regards
Kunihiko Hayashi

\
 
 \ /
  Last update: 2023-03-27 01:11    [W:0.118 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site