Messages in this thread | | | Date | Wed, 22 Mar 2023 11:27:48 +0900 | Subject | Re: [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer | From | Kunihiko Hayashi <> |
| |
Hi Rob,
On 2023/03/20 2:30, Rob Herring wrote: > Add support for Socionext Synquacer SDHCI. This binding has been in use > for > some time. > > The interrupts were not documented. The driver only uses the first > interrupt, but the DT and example have 2 interrupts. The 2nd one is > unknown. "dma-coherent" was also not documented, but is used on Synquacer.
Surely "interrupts" is needed. The 2nd interrupt seems to come from the card, though, the driver isn't supported it.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > v2: > - Rebase on conversion done by Kunihiko > --- > .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml > b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml > index 73d747e917f3..430b62899397 100644 > --- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml > +++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml > @@ -14,9 +14,13 @@ allOf: > > properties: > compatible: > - enum: > - - fujitsu,mb86s70-sdhci-3.0 > - - socionext,f-sdh30-e51-mmc > + oneOf: > + - items: > + - const: socionext,synquacer-sdhci > + - const: fujitsu,mb86s70-sdhci-3.0 > + - enum: > + - fujitsu,mb86s70-sdhci-3.0 > + - socionext,f-sdh30-e51-mmc > > reg: > maxItems: 1 > @@ -29,6 +33,11 @@ properties: > - const: iface > - const: core > > + dma-coherent: true > + > + interrupts: > + maxItems: 2 > + > resets: > maxItems: 1 >
--- Best Regards Kunihiko Hayashi
| |