Messages in this thread | | | Date | Mon, 20 Mar 2023 11:25:26 +0100 | From | Simon Horman <> | Subject | Re: Re: [PATCH v2] Bluetooth: 6LoWPAN: Add missing check for skb_clone |
| |
On Mon, Mar 20, 2023 at 11:08:46AM +0800, Jiasheng Jiang wrote: > On Mon, Mar 20, 2023 at 10:54:40AM +0800, Jiasheng Jiang wrote: > > On Sat, Mar 18, 2023 at 05:03:21AM +0800, Simon Horman wrote: > >> On Wed, Mar 15, 2023 at 03:06:21PM +0800, Jiasheng Jiang wrote: > >>> Add the check for the return value of skb_clone since it may return NULL > >>> pointer and cause NULL pointer dereference in send_pkt. > >>> > >>> Fixes: 18722c247023 ("Bluetooth: Enable 6LoWPAN support for BT LE devices") > >>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > >>> --- > >>> Changelog: > >>> > >>> v1 -> v2: > >>> > >>> 1. Modify the error handling in the loop. > >> > >> I think that at a minimum this needs to be included in the patch description. > >> Or better, in it's own patch with it's own fixes tag. > >> It seems like a fundamental change to the error handling to me. > > > > I will submit a separate patch to modify the error handling in the loop. > > You can directly review the v1. > > Link:https://lore.kernel.org/all/20230313090346.48778-1-jiasheng@iscas.ac.cn/ > > I think it would be better to send a patch series.
Yes, agreed.
| |