lkml.org 
[lkml]   [2023]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 04/22] perf test: Fix memory leak in symbols
From
On 20/03/23 05:37, Ian Rogers wrote:
> machine__delete doesn't delete threads.

Which begs the question: Shouldn't it?

> Add call to delete threads
> ahead of deleting the machine.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/symbols.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/symbols.c b/tools/perf/tests/symbols.c
> index 057b16df6416..0793f8f419e2 100644
> --- a/tools/perf/tests/symbols.c
> +++ b/tools/perf/tests/symbols.c
> @@ -38,6 +38,7 @@ static int init_test_info(struct test_info *ti)
> static void exit_test_info(struct test_info *ti)
> {
> thread__put(ti->thread);
> + machine__delete_threads(ti->machine);
> machine__delete(ti->machine);
> }
>

\
 
 \ /
  Last update: 2023-03-27 01:07    [W:0.152 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site