lkml.org 
[lkml]   [2023]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.2 12/30] scsi: hisi_sas: Check devm_add_action() return value
    Date
    From: Kang Chen <void0red@gmail.com>

    [ Upstream commit 06d1a90de60208054cca15ef200138cfdbb642a9 ]

    In case devm_add_action() fails, check it in the caller of
    interrupt_preinit_v3_hw().

    Link: https://lore.kernel.org/r/20230227031030.893324-1-void0red@gmail.com
    Signed-off-by: Kang Chen <void0red@gmail.com>
    Acked-by: Xiang Chen <chenxiang66@hisilicon.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
    index 0c3fcb8078062..a63279f55d096 100644
    --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
    +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
    @@ -2495,8 +2495,7 @@ static int interrupt_preinit_v3_hw(struct hisi_hba *hisi_hba)
    hisi_hba->cq_nvecs = vectors - BASE_VECTORS_V3_HW;
    shost->nr_hw_queues = hisi_hba->cq_nvecs;

    - devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev);
    - return 0;
    + return devm_add_action(&pdev->dev, hisi_sas_v3_free_vectors, pdev);
    }

    static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-03-27 01:07    [W:2.767 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site