Messages in this thread | | | From | Masahiro Yamada <> | Date | Sun, 19 Mar 2023 16:43:47 +0900 | Subject | Re: [PATCH] kheaders: prefer gtar over tar for better compatibility |
| |
I thought I had relied this before, but something awkward was happening because the original email was addressed to yamada.masahiro@socionext.com, which is no longer valid.
Resending from masahiroy@kernel.org...
In the top Makefile, please add
TAR = tar
and export TAR.
In kernel/gen_kheaders.sh, please replace 'tar' with ${TAR:-tar}
On Gentoo systems, you can do
$ make TAR=gtar
or if you need to run gen_kheaders.sh directly
$ TAR=gtar scripts/gen_kheaders.sh
Thanks.
On Fri, Mar 17, 2023 at 9:05 AM Sam James <sam@gentoo.org> wrote: > > > Sam James <sam@gentoo.org> writes: > > > [[PGP Signed Part:Undecided]] > > > > > >> On 17 Jan 2023, at 19:01, Sam James <sam@gentoo.org> wrote: > >> > >> > >> > >>> On 25 Dec 2022, at 16:33, Michał Górny <mgorny@gentoo.org> wrote: > >>> > >>> On Sun, 2022-12-25 at 01:45 +0900, Masahiro Yamada wrote: > >>>> Instead of inserting a workaround like this, > >>>> another way is to allow users to override a variable > >>>> from the command line. > >>>> > >>>> > >>>> See the top Makefile, for example, > >>>> > >>>> > >>>> AWK = awk > >>>> > >>>> > >>>> Then, users can do "make AWK=gawk" > >>> > >>> I'm sorry but are you requesting that I remove the check and use $TAR > >>> instead, or allow overriding with TAR, and fall back to gtar or tar > >>> respectively? If the former, should the script unconditionally assume > >>> that TAR will be always set in the environment, or include fallback to > >>> tar for when the script is run directly? > >> > >> > >> Masahiro, what do you reckon? Thanks. > >> > > > > Ping. > > ping^2. We'd really love to get this in to fix a bug for our users in > Gentoo. > > > > >> Best, > >> sam > > > > > > [[End of PGP Signed Part]] >
-- Best Regards Masahiro Yamada
| |