Messages in this thread | | | Date | Sun, 19 Mar 2023 20:22:14 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c |
| |
On Sun, Mar 19, 2023 at 12:07:43PM +0000, Lorenzo Stoakes wrote: > On Sun, Mar 19, 2023 at 01:42:14PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" <rppt@kernel.org> > > > > The get_page_from_free_area() helper is only used in mm/page_alloc.c so > > move it there to reduce noise in include/linux/mmzone.h
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Good catch, I wonder if there are more functions like this that can be dropped > from headers?
I don't think anything outside mm/ has any reason to see 'struct free_area'. Unfortunately, it's a field in struct zone, so moving it out of mmzone.h will be hard (unless we can move struct zone out of mmzone.h?)
free_area_empty() can move to mm/internal.h though
| |