Messages in this thread | | | Date | Sun, 19 Mar 2023 02:50:56 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() |
| |
On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > /* for /proc/kcore */ > -extern long vread(char *buf, char *addr, unsigned long count); > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter);
I don't love the order of the arguments here. Usually we follow memcpy() and have (dst, src, len). This sometimes gets a bit more complex when either src or dst need two arguments, but that's not the case here.
| |