lkml.org 
[lkml]   [2023]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
Bagas Sanjaya wrote:
> On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote:
> > Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
>
> If I only see the subject above, which functions are renamed? I have
> to see the actual diff if the patch description doesn't answer that.
> In this case, I think the proper subject would be `[PATCH v3] staging:
> sm750: Rename sm750_hw_cursor_* functions to snake_case`.

No. The oneliner is a brief overview.

It is perfectly appropriate to have to look at the diff to see what was
done. The commit message is to state what the problem was and how it was
fixed.

Ira

\
 
 \ /
  Last update: 2023-03-27 01:06    [W:0.892 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site