Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 17 Mar 2023 10:45:42 +0000 | Subject | Re: [PATCH v2 8/8] ASoC: cs35l56: Add driver for Cirrus Logic CS35L56 | From | Richard Fitzgerald <> |
| |
On 17/03/2023 10:40, Richard Fitzgerald wrote: > On 16/03/2023 20:15, kernel test robot wrote: >> Hi Richard, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on broonie-sound/for-next] >> [also build test ERROR on linus/master v6.3-rc2 next-20230316] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: >> https://github.com/intel-lab-lkp/linux/commits/Richard-Fitzgerald-via-Alsa-devel/ASoC-wm_adsp-Use-no_core_startstop-to-prevent-creating-preload-control/20230313-235605 >> base: >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git >> for-next >> patch link: >> https://lore.kernel.org/r/167872265923.26.336497278776737619%40mailman-core.alsa-project.org >> patch subject: [PATCH v2 8/8] ASoC: cs35l56: Add driver for Cirrus >> Logic CS35L56 >> config: s390-randconfig-r044-20230313 >> (https://download.01.org/0day-ci/archive/20230317/202303170422.ZYpOtc4P-lkp@intel.com/config) >> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project >> 67409911353323ca5edf2049ef0df54132fa1ca7) >> reproduce (this is a W=1 build): >> wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install s390 cross compiling tool for clang build >> # apt-get install binutils-s390x-linux-gnu >> # >> https://github.com/intel-lab-lkp/linux/commit/5856c94d659f9c9963f5c37762cf201e1f1765e9 >> git remote add linux-review >> https://github.com/intel-lab-lkp/linux >> git fetch --no-tags linux-review >> Richard-Fitzgerald-via-Alsa-devel/ASoC-wm_adsp-Use-no_core_startstop-to-prevent-creating-preload-control/20230313-235605 >> git checkout 5856c94d659f9c9963f5c37762cf201e1f1765e9 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 O=build_dir ARCH=s390 olddefconfig >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 O=build_dir ARCH=s390 SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> | Reported-by: kernel test robot <lkp@intel.com> >> | Link: >> https://lore.kernel.org/oe-kbuild-all/202303170422.ZYpOtc4P-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> s390x-linux-ld: sound/soc/codecs/cs35l56.o: in function >> `cs35l56_dsp_work': >>>> sound/soc/codecs/cs35l56.c:887: undefined reference to >>>> `sdw_write_no_pm' >>>> s390x-linux-ld: sound/soc/codecs/cs35l56.c:888: undefined reference >>>> to `sdw_read_no_pm' >>>> s390x-linux-ld: sound/soc/codecs/cs35l56.c:889: undefined reference >>>> to `sdw_write_no_pm' >> s390x-linux-ld: sound/soc/codecs/cs35l56.c:953: undefined >> reference to `sdw_write_no_pm' >> s390x-linux-ld: sound/soc/codecs/cs35l56.o: in function >> `cs35l56_sdw_dai_hw_params': >>>> sound/soc/codecs/cs35l56.c:710: undefined reference to >>>> `sdw_stream_add_slave' >> s390x-linux-ld: sound/soc/codecs/cs35l56.o: in function >> `cs35l56_sdw_dai_hw_free': >>>> sound/soc/codecs/cs35l56.c:729: undefined reference to >>>> `sdw_stream_remove_slave' >> > > I don't understand what's happened here. > include/linux/soundwire/sdw.h provides inline dummy versions of these > functions if !IS_ENABLED(CONFIG_SOUNDWIRE) so how can they be > undefined reference?
Oh, I see it now. CONFIG_SOUNDWIRE=m but CONFIG_SND_SOC_CS35L56=y so it can't link.
| ![\](/images/icornerr.gif) |