lkml.org 
[lkml]   [2023]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC/RFT PATCH net-next 0/4] KSZ DSA driver: xMII speed adjustment and partial reg_fields conversion
Date
Hi,

Yesterday I picked up this patch and resubmitted it:
https://patchwork.kernel.org/project/netdevbpf/patch/20230222031738.189025-1-marex@denx.de/
here:
https://patchwork.kernel.org/project/netdevbpf/patch/20230315231916.2998480-1-vladimir.oltean@nxp.com/

and today I'm trying to address the rest of the points brought up in
that conversation, namely:

- commit c476bede4b0f ("net: dsa: microchip: ksz8795: use common xmii
function") stopped adjusting the xMII port speed on KSZ8795, does it
still work? No idea. Patch 3/4 deals with that.

- Mapping P_XMII_CTRL_0 and P_XMII_CTRL_1 to the same value on KSZ8795
raised some eyebrows, and some reading shows that it is also partially
incorrect (see patch 2/4). This is also where I propose to convert to
reg_fields.

As it turns out, patch 2/4 is a dependency for patch 3/4, even if 3/4
may be a fix.

Patch 1/4 is a dependency of 2/4.

Patch 4/4 is something I also noticed during review. I left it at the
end so that it won't conflict with something that could reasonably be
submitted as a bug fix.

ABSOLUTELY NO TESTING WAS DONE. I don't have the hardware.

THIS BREAKS EVERYTHING EXCEPT FOR KSZ8795. Any testers should test on
that if possible (due to both patches 2/4, and 3/4).

Vladimir Oltean (4):
net: dsa: microchip: add an enum for regmap widths
net: dsa: microchip: partial conversion to regfields API for KSZ8795
(WIP)
net: dsa: microchip: allow setting xMII port speed/duplex on
KSZ8765/KSZ8794/KSZ8795
net: dsa: microchip: remove unused dev->dev_ops->phylink_mac_config()

drivers/net/dsa/microchip/ksz8795.c | 45 ++--
drivers/net/dsa/microchip/ksz8863_smi.c | 11 +-
drivers/net/dsa/microchip/ksz9477.c | 24 +--
drivers/net/dsa/microchip/ksz9477_i2c.c | 11 +-
drivers/net/dsa/microchip/ksz_common.c | 256 +++++++++++++----------
drivers/net/dsa/microchip/ksz_common.h | 110 +++++++---
drivers/net/dsa/microchip/ksz_spi.c | 6 +-
drivers/net/dsa/microchip/lan937x_main.c | 8 +-
8 files changed, 299 insertions(+), 172 deletions(-)

--
2.34.1

\
 
 \ /
  Last update: 2023-03-27 01:04    [W:0.138 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site