lkml.org 
[lkml]   [2023]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/9] coresight: Rename nr_outports to nr_outconns
From
On 10/03/2023 16:06, James Clark wrote:
> Rename to avoid confusion between port number and the index in the
> connection array. The port number is already stored in the connection,
> and in a later commit the connection array will be appended to, so
> the length of it will no longer reflect the number of ports.
>
> No functional changes.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 32 ++++++++---------
> .../hwtracing/coresight/coresight-platform.c | 34 +++++++++----------
> .../hwtracing/coresight/coresight-tmc-etr.c | 2 +-
> include/linux/coresight.h | 10 +++---
> 4 files changed, 39 insertions(+), 39 deletions(-)
>

...

> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 322d7273e122..cdf0d1def778 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -102,13 +102,13 @@ union coresight_dev_subtype {
> * struct coresight_platform_data - data harvested from the firmware
> * specification.
> *
> - * @nr_inport: Number of elements for the input connections.
> - * @nr_outport: Number of elements for the output connections.
> - * @conns: Sparse array of nr_outport connections from this component.
> + * @nr_inconns: Number of elements for the input connections.
> + * @nr_outconns: Number of elements for the output connections.
> + * @conns: Sparse array of nr_outconns connections from this component.

s/conns/out_conns/

Otherwise looks good to me.

Suzuki

\
 
 \ /
  Last update: 2023-03-27 01:04    [W:3.114 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site