lkml.org 
[lkml]   [2023]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v18 03/15] shmem: Implement splice-read
On Tue, Mar 14, 2023 at 3:08 PM David Howells <dhowells@redhat.com> wrote:
>
\> +static size_t splice_zeropage_into_pipe(...
> ...
> + *buf = (struct pipe_buffer) {
> + .ops = &zero_pipe_buf_ops,
> + .page = ZERO_PAGE(0),
> + .offset = offset,
> + .len = size,
> + };
> + get_page(buf->page);

That

+ get_page(buf->page);

is still there, and now it's doubly wrong because it's never dropped
and will eventually overflow that count that shouldn't even be there.

Linus

\
 
 \ /
  Last update: 2023-03-27 01:00    [W:0.117 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site