lkml.org 
[lkml]   [2023]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v17 02/14] splice: Make do_splice_to() generic and export it
Date
Christoph Hellwig <hch@infradead.org> wrote:

> > -static long do_splice_to(struct file *in, loff_t *ppos,
> > - struct pipe_inode_info *pipe, size_t len,
> > - unsigned int flags)
> > +long vfs_splice_read(struct file *in, loff_t *ppos,
>
> The (pre-existing) long here is odd given that ->splice_read
> returns a ssize_t. This might be a good time to fix that up.

There's a while lot of places in splice.c that use long rather than ssize_t.
I can produce a separate patch that changes them all, but that should perhaps
be separate to this.

David

\
 
 \ /
  Last update: 2023-03-27 01:00    [W:0.194 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site