Messages in this thread | | | Date | Tue, 14 Mar 2023 21:42:28 +0100 | From | Andi Shyti <> | Subject | Re: [PATCH] iio: adc: qcom-pm8xxx-xoadc: Remove useless condition in pm8xxx_xoadc_parse_channel() |
| |
On Tue, Mar 14, 2023 at 10:37:09PM +0300, Kasumov Ruslan wrote: > The left side of the loop condition never becomes false. > hwchan cannot be NULL, because it points to elements of the > hw_channels array that takes one of 4 predefined values: > pm8018_xoadc_channels, pm8038_xoadc_channels, > pm8058_xoadc_channels, pm8921_xoadc_channels. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 63c3ecd946d4 ("iio: adc: add a driver for Qualcomm PM8xxx HK/XOADC")
It wasn't broken before, it wasn't causing any harm. It's not a fix, it's a cleanup. Please, remove remove the "Fixes:" tag.
> Signed-off-by: Kasumov Ruslan <s02210418@gse.cs.msu.ru> > --- > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > index eb424496ee1d..64a3aeb6261c 100644 > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > @@ -758,7 +758,7 @@ static int pm8xxx_xoadc_parse_channel(struct device *dev, > /* Find the right channel setting */ > chid = 0; > hwchan = &hw_channels[0]; > - while (hwchan && hwchan->datasheet_name) { > + while (hwchan->datasheet_name) {
With the fixes tag removed:
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks, Andi
> if (hwchan->pre_scale_mux == pre_scale_mux && > hwchan->amux_channel == amux_channel) > break; > -- > 2.34.1 >
| |